Wiki source for Mod026bDoubleDoubleQuoteInsecurity

Show raw source

==== Wikka Mod 026 ====
Type: Bug Fix
**[[ | Joe Delaney]]**
[[ |]] //(archived)//

==Double Double-quote insecurity==
It was possible to insert xhtml or other escaped code using double double-quotes. This has been stopped by changing
formatters/wakka.php line to use htmlspecialchars.

More changes along this line might be necessary, with htmlspecialchars() being used or (url encoding) any time text is passed straight through the formatter (urls into a link, for example).

return $matches[1];
return htmlspecialchars($matches[1]);

// escaped text
else if (preg_match("/^\"\"(.*)\"\"$/s", $thing, $matches))
return htmlspecialchars($matches[1]);

Valid XHTML :: Valid CSS: :: Powered by WikkaWiki